perf: eliminate Func and closure allocation in DedicatedThreadExecutor#4455
Merged
thomhurst merged 1 commit intothomhurst:mainfrom Jan 17, 2026
Merged
Conversation
TimothyMakkison
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
TimothyMakkison
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
TimothyMakkison
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
Owner
SummaryEliminates closure and Func allocation in DedicatedThreadExecutor by passing action as a parameter to StartNew instead of capturing it. Critical IssuesNone found ✅ SuggestionsNone - this is a clean performance optimization with measurable benefit in a hot path. Verdict✅ APPROVE - No critical issues The static lambda + parameter passing approach correctly eliminates the closure allocation while maintaining the same behavior. The cast back to |
auto-merge was automatically disabled
January 17, 2026 01:12
Head branch was pushed to by a user without write access
TimothyMakkison
force-pushed
the
ded_thread_start
branch
from
7ffe62d to
7254646
Compare
TimothyMakkison
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
TimothyMakkison
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
TimothyMakkison
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
This was referenced Jan 18, 2026
This was referenced Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
actionintoStartNeweliminating allocation ofFunc<TResult>and associated closureBefore
After